[e-lang] TraversalKey bug fixed; Equalizer questions

[Mark S. Miller]

Kevin Reid wrote:
> The bug described at
> http://sourceforge.net/tracker/index.php? 
> func=detail&aid=1605810&group_id=75274&atid=551529
> has been fixed for E-on-Java in revision 352.
> 
> I do not have access to mark the bug as fixed in the tracker. (My SF  
> username is "kpreid".)

This bug is now fixed/closed in the tracker, thanks! You have also been added
to the project with full permissions. Welcome!


> Some questions resulting from this work:
> 
> 1. Am I correct that Equalizer#samenessHash and  
> Equalizer#samenessFringe are exactly the same except that  
> samenessHash computes hashes and switches to samenessFringe past the  
> hash depth, and that samenessFringe has some early-exit cases?

As best I can recall, yes.


> 2. If so, is there a way this code could be made less duplicated?

I don't know, but I hope so.



> 3. When comparing two references, the current code keeps a stack of  
> containing objects which are currently being compared, to allow  
> comparing cycles. Would it be incorrect (ignoring efficiency for the  
> moment) to remember all such pairs through an entire comparison,  
> rather than forgetting them as sub-comparisons finish?

Yes, either algorithm is correct.


I will answer your fourth question separately.

-- 
Text by me above is hereby placed in the public domain

     Cheers,
     --MarkM