[e-lang] Bug: deENodeKit inconsistent with makeFinalPattern
kpreid at mac.com
Sat Aug 25 21:01:19 EDT 2007
On Aug 25, 2007, at 14:50, Mark Miller wrote:
> On 8/24/07, Kevin Reid <kpreid at mac.com> wrote:
>> deENodeKit expects makeFinalPattern to have a 3ary method which takes
>> a string noun; makeFinalPattern has only 4 and 5ary methods taking
> It looks like deENodeKit's makeFinalPattern(null, name, null)
> should be
> translated into an actual
> makeFinalPattern(null, makeSimpleNounExpr(null, name, null),
> null, null)
> Does this seem right?
It is obvious that that will fix it. What I wanted to know was what
the *intent* was, and whether deENodeKit or makeFinalPattern is the
better thing to be changed.
Having dug in the repository history a bit (thanks for importing many
old E releases!), I now see that FinalPattern once had a String
rather than NounExpr child, and once did not have a guard.
Therefore, I conclude that deENodeKit has not kept up, and is what
should be fixed. I will do so for E-on-Java and E-on-CL.
Kevin Reid <http://homepage.mac.com/kpreid/>
More information about the e-lang