[e-lang] Patches for review, mostly on ProcessSugar

Kevin Reid kpreid at switchb.org
Mon May 16 06:57:15 PDT 2011


While working on an E project I wrote these changes to E-on-Java. They are simple and I am reasonably confident in their correctness, but I would appreciate a review, especially of #2 and #4 which are semantic changes.

The patches were generated by git format-patch; any suggestions on better ways to publish a bunch of commits for review are welcome. (I have moved my workflow to using git-svn instead of svn, as does Thomas Leonard.)

#1 fixes a typo bug: Sugar method Process#attachStderr actually attaches stdout. It also notes that these operations as defined leak vats.

#2 adds an operation Process#terminates/0; it is like resultsVow/0 in that it returns a promise for when the process terminates, but it does not claim stdout or stderr.

#3 fixes misspellings of "opening" and "opener" with two "n"s.

#4 makes CharPipeAdapter flush its Writer (and also copy in bulk); without this, output may be indefinitely delayed or lost if nothing other than the CharPipeAdapter is working with the Writer and the Writer buffers indefinitely.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bug-Process-attachStderr-2-took-stdout-instead-of-st.patch
Type: application/octet-stream
Size: 1860 bytes
Desc: not available
Url : http://www.eros-os.org/pipermail/e-lang/attachments/20110516/14e7767d/attachment-0004.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-terminates-0-to-Process-like-resultsVow-but-does.patch
Type: application/octet-stream
Size: 1701 bytes
Desc: not available
Url : http://www.eros-os.org/pipermail/e-lang/attachments/20110516/14e7767d/attachment-0005.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-all-misspellings-of-opener-and-opening-with-two-.patch
Type: application/octet-stream
Size: 23947 bytes
Desc: not available
Url : http://www.eros-os.org/pipermail/e-lang/attachments/20110516/14e7767d/attachment-0006.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Make-CharPipeAdapter-autoflush-its-output.patch
Type: application/octet-stream
Size: 1760 bytes
Desc: not available
Url : http://www.eros-os.org/pipermail/e-lang/attachments/20110516/14e7767d/attachment-0007.obj 
-------------- next part --------------


-- 
Kevin Reid                                  <http://switchb.org/kpreid/>



More information about the e-lang mailing list