[eros-cvs] cvs commit: eros/src/base/cross/lib/erosimg Volume.cxx Volume.hxx

[Charles Landau]

"Jonathan S. Shapiro" wrote:

> As you ifdef out the capability page support, please wrap it in #ifdef
> DEAD_CAP_PAGES rather than #if 0. The problem with #if 0 is that when we
> strip things out we have to do a lot of reading to figure out what/why
> we are stripping.

It seems to me that

#if 0 /* dead cap pages */

is just as informative as

#ifdef DEAD_CAP_PAGES

and also conveys the information that there is no intention of enabling
this code by defining DEAD_CAP_PAGES.

The only reason I didn't just delete this stuff is that I want to look at
the deleted code to see what else can be deleted as a consequence, but I
don't have time to do that right now.